Introduces the FromQuery and IntoQuery traits#3565
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 9959b92): https://yew-rs--pr3565-master-lh2bk2hc.web.app (expires Mon, 21 Apr 2025 09:52:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - SSRYew MasterDetails
Pull RequestDetails
|
Size ComparisonDetails
✅ None of the examples has changed their size significantly. |
Contributor
Author
|
@ranile Can this be added to the 0.22 release? I just have some clips problems which are not from me? Which are blocking the merge.... |
Member
|
Can you update some relevant docs. Particularly For example here: yew/website/docs/concepts/router.mdx Lines 350 to 353 in 57b29f2 |
Contributor
Author
|
@Madoshakalaka I updated the documentation. I hope it's good enough. Let me know, if something more should be done. |
Madoshakalaka
requested changes
Apr 14, 2025
Madoshakalaka
approved these changes
Apr 30, 2025
Member
Madoshakalaka
left a comment
Madoshakalaka
left a comment
There was a problem hiding this comment.
Looks good. Thanks for contributing.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces the FromQuery and IntoQuery traits following the gloo_history approach.
Checklist